Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks
Date	2016-10-13 13:50 +0200
Message-ID	<srMGm-30B-13@gated-at.bofh.it> (permalink)
References	<sr92h-15w-13@gated-at.bofh.it> <sr92h-15w-19@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

Hi Carlos,

On Tue, 11 Oct 2016 18:24:39 +0100, Carlos Palminha wrote:
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
>  drivers/i2c/busses/i2c-piix4.c | 94 ++++++++++++++++++++++++------------------
>  1 file changed, 54 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 5d6f637..85b1052 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> (...)
>  /*
> -   Supports:
> -	Intel PIIX4, 440MX
> -	Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> -	ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> -	AMD Hudson-2, ML, CZ
> -	SMSC Victory66
> -
> -   Note: we assume there can only be one device, with one or more
> -   SMBus interfaces.
> -   The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> -   For devices supporting multiple ports the i2c_adapter should provide
> -   an i2c_algorithm to access them.
> -*/
> + * Supports:
> + *	Intel PIIX4, 440MX
> + *	Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> + *	ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> + *	AMD Hudson-2, ML, CZ
> + *	SMSC Victory66
> + *
> + *  Note: we assume there can only be one device, with one or more

There's an extra space before "Note:", please remove.

> + * SMBus interfaces.
> + * The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> + * For devices supporting multiple ports the i2c_adapter should provide
> + * an i2c_algorithm to access them.
> + */

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-10-11 19:30 +0200
  Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments  blocks Jean Delvare <jdelvare@suse.de> - 2016-10-13 13:50 +0200

csiph-web