Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500130
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Intel-gfx] [patch] drm/i915: fix a read size argument |
| Date | 2016-10-13 12:00 +0200 |
| Message-ID | <srKXT-1LD-1@gated-at.bofh.it> (permalink) |
| References | <srK1Q-1cz-5@gated-at.bofh.it> <srKbv-1uX-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Oct 13, 2016 at 10:01:03AM +0100, Chris Wilson wrote:
> On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> > We want to read 3 bytes here, but because the parenthesis are in the
> > wrong place we instead read:
> >
> > sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
> >
> > which is one byte.
> >
> > Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Oops, does smatch catch this?
Yeah. It does.
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch] drm/i915: fix a read size argument Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-13 11:00 +0200
Re: [patch] drm/i915: fix a read size argument Eric Engestrom <eric.engestrom@imgtec.com> - 2016-10-13 11:10 +0200
Re: [Intel-gfx] [patch] drm/i915: fix a read size argument Chris Wilson <chris@chris-wilson.co.uk> - 2016-10-13 11:10 +0200
Re: [Intel-gfx] [patch] drm/i915: fix a read size argument Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-13 12:00 +0200
Re: [patch] drm/i915: fix a read size argument walter harms <wharms@bfs.de> - 2016-10-13 11:50 +0200
Re: [patch] drm/i915: fix a read size argument Jani Nikula <jani.nikula@linux.intel.com> - 2016-10-13 14:20 +0200
csiph-web