Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500047

Re: [PATCH] cpufreq: conservative: Fix next frequency selection

Show all headers | View raw

On 12-10-16, 21:47, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Commit d352cf47d93e (cpufreq: conservative: Do not use transition
> notifications) overlooked the case when the "frequency step" used
> by the conservative governor is small relative to the distances
> between the available frequencies and broke the algorithm by
> using policy->cur instead of the previously requested frequency
> when computing the next one.
> 
> As a result, the governor may not be able to go outside of a narrow
> range between two consecutive available frequencies.
> 
> Fix the problem by making the governor save the previously requested
> frequency and select the next one relative that value (unless it is
> out of range, in which case policy->cur will be used instead).
> 
> Fixes: d352cf47d93e (cpufreq: conservative: Do not use transition notifications)
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=177171
> Reported-and-tested-by: Aleksey Rybalkin <aleksey@rybalkin.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_conservative.c |   19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: conservative: Fix next frequency selection "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-12 21:50 +0200
  Re: [PATCH] cpufreq: conservative: Fix next frequency selection Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-13 08:30 +0200

csiph-web