Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500010

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

Show all headers | View raw

On Wed, Oct 12, 2016 at 04:58:35PM -0600, Andreas Dilger wrote:
> On Mar 17, 2015, at 8:08 PM, Taesoo Kim <tsgatesv@gmail.com> wrote:
> > 
> > When 'jh->b_transaction == transaction' (asserted by below)
> > 
> >         J_ASSERT_JH(jh, (jh->b_transaction == transaction || ...
> > 
> > 'journal->j_list_lock' will be incorrectly unlocked, since
> > spin_lock() is called only in the 'if' and 'else-if' blocks but
> > not in the missing 'else' case, which results in a hang or an oops....
> > 
> > Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
> 
> We've hit this repeatedly on kernels with commit v3.14-rc2-30-g6e4862a
> "jbd2: minimize region locked by j_list_lock in journal_get_create_access"
> under heavy load and this patch has fixed the problem.
> 
> It should also be considered for stable kernels after 3.14.
> 
> [I've updated the above commit message slightly to give more details.]
> 
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>

Thanks, applied.

Apologies, this got lost which is why I hadn't handled it earlier.

	   	    	       	      - Ted

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock Andreas Dilger <adilger@dilger.ca> - 2016-10-13 01:00 +0200
  Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock Theodore Ts'o <tytso@mit.edu> - 2016-10-13 05:30 +0200

csiph-web