Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499988
| From | Theodore Ts'o <tytso@mit.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ext4: super.c: Update logging style using PR_CONT |
| Date | 2016-10-13 02:50 +0200 |
| Message-ID | <srCnD-3SP-9@gated-at.bofh.it> (permalink) |
| References | <srh9v-6ic-3@gated-at.bofh.it> <srpgJ-3eb-13@gated-at.bofh.it> <srsRk-5Ir-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Oct 12, 2016 at 07:32:10AM -0700, Joe Perches wrote:
> On Wed, 2016-10-12 at 12:41 +0200, Jan Kara wrote:
> > On Tue 11-10-16 18:57:58, Joe Perches wrote:
> > > Recent commit require line continuing printks to use PR_CONT.
> > >
> > > Update super.c to use PR_CONT and use vsprintf extension %pV
> > > to avoid a printk/vprintk/printk("\n") sequence as well.
> >
> >
> > Looks good. You can add:
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
>
> Except the subject and commit bodyis broken and should use KERN_CONT not PR_CONT
>
> Ted, can you please fix when applying or do you want a resubmit?
I'll fix it up, no worries!.
- Ted
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ext4: super.c: Update logging style using PR_CONT Joe Perches <joe@perches.com> - 2016-10-12 04:10 +0200
Re: [PATCH] ext4: super.c: Update logging style using PR_CONT Jan Kara <jack@suse.cz> - 2016-10-12 12:50 +0200
Re: [PATCH] ext4: super.c: Update logging style using PR_CONT Joe Perches <joe@perches.com> - 2016-10-12 16:40 +0200
Re: [PATCH] ext4: super.c: Update logging style using PR_CONT Theodore Ts'o <tytso@mit.edu> - 2016-10-13 02:50 +0200
Re: [PATCH] ext4: super.c: Update logging style using PR_CONT Theodore Ts'o <tytso@mit.edu> - 2016-10-13 05:20 +0200
csiph-web