Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1499992

Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT

From Jakub Kicinski <kubakici@wp.pl>
Newsgroups linux.kernel
Subject Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT
Date 2016-10-13 03:20 +0200
Message-ID <srCQF-4l5-1@gated-at.bofh.it> (permalink)
References <sodc5-6BL-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 3 Oct 2016 10:14:32 -0500, Julia Cartwright wrote:
> The use of IRQF_ONESHOT when registering an interrupt handler with
> request_irq() is non-sensical.
> ...

Disabling the irq when kthread is pending as mentioned here:

http://www.spinics.net/lists/linux-rt-users/msg14673.html

could be beneficial but this is definitely a step in the right
direction!

Acked-by: Jakub Kicinski <kubakici@wp.pl>

Thanks a lot Julia!

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT Julia Cartwright <julia@ni.com> - 2016-10-03 17:20 +0200
  Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT Jakub Kicinski <kubakici@wp.pl> - 2016-10-13 03:20 +0200
  [PATCH v2] sc16is7xx: Drop bogus use of IRQF_ONESHOT Julia Cartwright <julia@ni.com> - 2016-10-13 17:50 +0200

csiph-web