Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498998

Re: [PATCH 1/8] vfs - change d_manage() to take a struct path

Show all headers | View raw

Ian Kent <raven@themaw.net> writes:

> For the autofs module to be able to reliably check if a dentry is a
> mountpoint in a multiple namespace environment the ->d_manage() dentry
> operation will need to take a path argument instead of a dentry.

Taking a quick look overall I see no issues with this series.  Overall
it seems straight forward.

On the nit side I expect saying const struct path * in the functions
that now take a struct path would be useful.

I suspect it would also be useful to say
	const struct path *path;
        path = &file->f_path;

In the one part of the code where you do that.  Instead of copying the
path out of the struct file.

Overall I expect that will keep down bugs at no reduction in usability.
Just a statement that the struct path won't change when it is passed
to various functions.

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] vfs - change d_manage() to take a struct path Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 8/8] vfs - remove unused have_submounts() function Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 7/8] autofs - use path_has_submounts() to fix unreliable  have_submount() checks Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 5/8] autofs - change autofs4_wait() to take struct path Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 3/8] vfs - add path_has_submounts() Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 6/8] autofs - use path_is_mountpoint() to fix unreliable  d_mountpoint() checks Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  [PATCH 4/8] autofs - change autofs4_expire_wait() to take struct  path Ian Kent <raven@themaw.net> - 2016-10-11 07:40 +0200
  Re: [PATCH 1/8] vfs - change d_manage() to take a struct path ebiederm@xmission.com (Eric W. Biederman) - 2016-10-11 18:10 +0200
    Re: [PATCH 1/8] vfs - change d_manage() to take a struct path Ian Kent <raven@themaw.net> - 2016-10-12 01:50 +0200

csiph-web