[PATCH 2/8] drm: mali-dp: Clear the config_valid flag before using it in wait_event.

From	Brian Starkey <brian.starkey@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/8] drm: mali-dp: Clear the config_valid flag before using it in wait_event.
Date	2016-10-11 16:30 +0200
Message-ID	<sr6e5-7Rm-9@gated-at.bofh.it> (permalink)
References	<sr6e5-7Rm-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Liviu Dudau <Liviu.Dudau@arm.com>

config_valid variable is used to signal the activation of the CVAL
request when the vsync interrupt has fired. malidp_set_and_wait_config_valid()
uses the variable in wait_event_interruptible_timeout without clearing it
first, so the wait is skipped.

Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
 drivers/gpu/drm/arm/malidp_drv.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 7987ebd..f2b1923 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -42,6 +42,7 @@ static int malidp_set_and_wait_config_valid(struct drm_device *drm)
 	struct malidp_hw_device *hwdev = malidp->dev;
 	int ret;
 
+	atomic_set(&malidp->config_valid, 0);
 	hwdev->set_config_valid(hwdev);
 	/* don't wait for config_valid flag if we are in config mode */
 	if (hwdev->in_config_mode(hwdev))
-- 
1.7.9.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/8] drm: mali-dp: Clear the config_valid flag before using it in wait_event. Brian Starkey <brian.starkey@arm.com> - 2016-10-11 16:30 +0200

csiph-web