Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498698

Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Oct 10, 2016 at 02:50:21PM +0200, Jean-Francois Moine wrote:
> On Mon, 10 Oct 2016 14:31:51 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> 
> > Hi,
> > 
> > On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote:
> > > This patch add the dt node for the syscon register present on the
> > > Allwinner H3.
> > > 
> > > Only two register are present in this syscon and the only one useful is
> > > the one dedicated to EMAC clock.
> > > 
> > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> > > index 8a95e36..1101d2f 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> > > @@ -140,6 +140,11 @@
> > >  		#size-cells = <1>;
> > >  		ranges;
> > >  
> > > +		syscon: syscon@01c00000 {
> > > +			compatible = "syscon";
> > 
> > It would be great to have a more specific compatible here in addition
> > to the syscon, like "allwinner,sun8i-h3-system-controller".
> 
> The System Control area is just like the PRCM area: it would be simpler
> to define the specific registers in the associated drivers.

Until you actually have to share those registers between different
devices, and then you're just screwed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/10] net-next: ethernet: add sun8i-emac driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:30 +0200
  [PATCH v4 07/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
  [PATCH v4 08/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange Pi 2 Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
    Re: [PATCH v4 08/10] ARM: dts: sun8i: Enable sun8i-emac on the  Orange Pi 2 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-12 11:10 +0200
    Re: [PATCH v4 08/10] ARM: dts: sun8i: Enable sun8i-emac on the  Orange Pi 2 Jean-Francois Moine <moinejf@free.fr> - 2016-10-12 11:10 +0200
  [PATCH v4 06/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
  [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
    Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on  multi_v7_defconfig Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-10 14:40 +0200
      Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on  multi_v7_defconfig LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-10-10 14:40 +0200
        Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on  multi_v7_defconfig Jean-Francois Moine <moinejf@free.fr> - 2016-10-10 15:20 +0200
          Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on  multi_v7_defconfig Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-11 11:50 +0200
            Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on  multi_v7_defconfig LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-10-12 10:40 +0200
  [PATCH v4 05/10] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
  [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
    Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-10 14:40 +0200
      Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Jean-Francois Moine <moinejf@free.fr> - 2016-10-10 15:00 +0200
        Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon  control module Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-11 12:00 +0200
  [PATCH v4 09/10] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-10-07 10:40 +0200
  Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver Joe Perches <joe@perches.com> - 2016-10-07 17:10 +0200

csiph-web