Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498081

Re: slab corruption with current -git

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: slab corruption with current -git
Date 2016-10-10 06:00 +0200
Message-ID <sqzUS-4zo-3@gated-at.bofh.it> (permalink)
References <sqxJo-3dZ-5@gated-at.bofh.it> <sqyP7-3YV-1@gated-at.bofh.it> <sqzLb-4wh-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 9 Oct 2016 20:41:17 -0700

> Note that the "correct way" of doing list operations also almost
> inevitably is the shortest way by far, since it gets rid of all the
> special cases. So the patch looks nice. It gets rid of the magic
> "nf_set_hooks_head()" thing too, because once you do list following
> right, the head is no different from any other pointer in the list.

Perhaps we should have some "slist" primitives added to
include/linux/list.h but since the comparison differs for each user I
guess it's hard to abstract in a way that's generic and inlines
properly.

I'll start taking a look at your patch and this stuff as well, thanks
Linus.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-09 23:40 +0200
  Re: slab corruption with current -git (was Re: [git pull] vfs pile 1  (splice)) Florian Westphal <fw@strlen.de> - 2016-10-10 03:00 +0200
    Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Aaron Conole <aconole@redhat.com> - 2016-10-10 03:40 +0200
      Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-10 04:50 +0200
        Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-10 05:50 +0200
          Re: slab corruption with current -git David Miller <davem@davemloft.net> - 2016-10-10 06:00 +0200
            Re: slab corruption with current -git David Miller <davem@davemloft.net> - 2016-10-10 10:30 +0200
              Re: slab corruption with current -git Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-10 18:20 +0200
              Re: slab corruption with current -git Michal Kubecek <mkubecek@suse.cz> - 2016-10-11 15:20 +0200
                Re: slab corruption with current -git Aaron Conole <aconole@bytheb.org> - 2016-10-11 16:10 +0200
          Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Aaron Conole <aconole@redhat.com> - 2016-10-10 15:50 +0200
            Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-10 18:40 +0200
              Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-10 21:10 +0200
                Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Aaron Conole <aconole@bytheb.org> - 2016-10-10 21:20 +0200
                Re: slab corruption with current -git David Miller <davem@davemloft.net> - 2016-10-11 02:40 +0200
                Re: slab corruption with current -git Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-11 03:00 +0200
          Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-11 07:50 +0200
            Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice)) Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-11 07:50 +0200
              Re: slab corruption with current -git David Miller <davem@davemloft.net> - 2016-10-11 11:00 +0200

csiph-web