Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498066

Re: net: BUG still has locks held in unix_stream_splice_read

Show all headers | View raw

On Sun, Oct 09, 2016 at 12:06:14PM +0200, Dmitry Vyukov wrote:
> I suspect this is:
> 
> commit 25869262ef7af24ccde988867ac3eb1c3d4b88d4
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date:   Sat Sep 17 21:02:10 2016 -0400
>     skb_splice_bits(): get rid of callback
>     since pipe_lock is the outermost now, we don't need to drop/regain
>     socket locks around the call of splice_to_pipe() from skb_splice_bits(),
>     which kills the need to have a socket-specific callback; we can just
>     call splice_to_pipe() and be done with that.

Unlikely, since that particular commit removes unlocking/relocking ->iolock
around the call of splice_to_pipe().  Original would've retaken the same
lock on the way out; it's not as if we could leave the syscall there.

It might be splice-related, but I don't believe that you've got the right
commit here.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: net: BUG still has locks held in unix_stream_splice_read Dmitry Vyukov <dvyukov@google.com> - 2016-10-09 12:10 +0200
  Re: net: BUG still has locks held in unix_stream_splice_read Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-10 04:50 +0200
    Re: net: BUG still has locks held in unix_stream_splice_read Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-10 05:20 +0200
      Re: net: BUG still has locks held in unix_stream_splice_read Dmitry Vyukov <dvyukov@google.com> - 2016-10-10 10:10 +0200

csiph-web