Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498579

Re: [PATCH 3/3] mtd: s3c2410: parse the device configuration from OF node

Show all headers | View raw

On Fri, Oct 07, 2016 at 07:28:10PM +0300, Krzysztof Kozlowski wrote:

> > +struct s3c24XX_nand_devtype_data {
> > +	enum s3c_cpu_type type;
> > +};
> > +
> > +struct s3c24XX_nand_devtype_data s3c2410_nand_devtype_data = {
> > +	.type = TYPE_S3C2410,
> > +};
> > +
> > +struct s3c24XX_nand_devtype_data s3c2412_nand_devtype_data = {
> > +	.type = TYPE_S3C2412,
> > +};
> > +
> > +struct s3c24XX_nand_devtype_data s3c2440_nand_devtype_data = {
> > +	.type = TYPE_S3C2440,
> > +};
> > +
> > +struct s3c24XX_nand_devtype_data s3c6400_nand_devtype_data = {
> > +	.type = TYPE_S3C2412,
> 
> All of these look like candidate for static const.
> 
> Additionally you are not actually differentiating between s3c2412 and
> s3c64xx so I think there is not need of samsung,s3c6400-nand compatible.
> Just use existing one.
> 
> Best regards,
> Krzysztof

You are right. I'll review and send V2.

Best regards,

Sergio Prado

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] mtd: s3c2410: parse the device configuration from OF node Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-06 01:50 +0200
  Re: [PATCH 3/3] mtd: s3c2410: parse the device configuration from OF  node Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-07 18:30 +0200
    Re: [PATCH 3/3] mtd: s3c2410: parse the device configuration from OF  node Sergio Prado <sergio.prado@e-labworks.com> - 2016-10-11 03:40 +0200
  Re: [PATCH 3/3] mtd: s3c2410: parse the device configuration from  OF node Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-12 11:20 +0200

csiph-web