Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1498431

Re: [PATCH] perf annotate: Cleanup arch specific stuff

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] perf annotate: Cleanup arch specific stuff
Date 2016-10-10 19:00 +0200
Message-ID <sqM5H-3BM-9@gated-at.bofh.it> (permalink)
References <sjS6d-2q3-3@gated-at.bofh.it> <sqJrb-2eB-13@gated-at.bofh.it> <sqLCG-3rZ-21@gated-at.bofh.it> <sqLMm-3uW-27@gated-at.bofh.it> <sqM5H-3BM-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Mon, Oct 10, 2016 at 10:19:28PM +0530, Ravi Bangoria escreveu:
> 
> 
> On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote:
> > On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote:
> >> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu:
> >>> Move arch specific stuff from util/annotate.c to their respective
> >>> files in util/annotate directory.
> >>>
> >>> No functionality changes.
> >>>
> >>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> >>> ---
> >>>  tools/perf/util/Build              |   1 +
> >>>  tools/perf/util/annotate.c         | 259 +++----------------------------------
> >>>  tools/perf/util/annotate.h         |  23 ++++
> >>>  tools/perf/util/annotate/Build     |   3 +
> >>>  tools/perf/util/annotate/arm.c     |  50 +++++++
> >>>  tools/perf/util/annotate/powerpc.c |  63 +++++++++
> >>>  tools/perf/util/annotate/x86.c     | 107 +++++++++++++++
> >> We already have a per arch area: tools/perf/arch/
> > I think this was done to support cross-arch annotate similar to the 
> > remote unwind support with util/libunwind/
> 
> Yes, because tools/perf/arch/ will only include host arch code.

Ok, thanks for clarifying.

- Arnaldo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf annotate: Cleanup arch specific stuff Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-10-10 16:10 +0200
  Re: [PATCH] perf annotate: Cleanup arch specific stuff Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-10 18:30 +0200
    Re: [PATCH] perf annotate: Cleanup arch specific stuff "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-10-10 18:40 +0200
      Re: [PATCH] perf annotate: Cleanup arch specific stuff Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-10 19:00 +0200
      Re: [PATCH] perf annotate: Cleanup arch specific stuff Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-10-10 22:30 +0200

csiph-web