Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes for ARM

From	Kim Phillips <kim.phillips@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes for ARM
Date	2016-10-10 18:00 +0200
Message-ID	<sqL9E-33e-13@gated-at.bofh.it> (permalink)
References	<sjS6d-2q3-3@gated-at.bofh.it> <sjS6e-2q3-5@gated-at.bofh.it> <soSIi-mA-15@gated-at.bofh.it> <sqJ7P-1T8-11@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw

On Mon, 10 Oct 2016 19:16:16 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> On Wednesday 05 October 2016 05:04 PM, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Sep 21, 2016 at 09:17:56PM +0530, Ravi Bangoria escreveu:
> >> From: Kim Phillips <kim.phillips@arm.com>
> >>
> >> For ARM we remove the list that contains non-arm insns, and
> >> instead add more maintainable branch instruction regex logic.
> > This one looks ok and actually is in the direction of having facilities
> > for all arches, should've come as infrastructure that then gets used by
> > ARM and powerpc.
> 
> This was authored by Kim and I didn't wanted to change that so I kept it
> at the end.

I don't mind if this gets merged higher up in the series, in fact, I
think it's preferred to adding the arm insn table and then removing it
in the same series.  Keeping my Author: isn't necessary either:
something like "Signed-off-by: Kim Phillips <...> [ARM bits]" will
suffice.

> I'm sending a cleanup patch that applies on top of this series. That patch
> moves most of arch specific stuff from util/annotate.c to
> util/annotate/<arch>.c. Please review it.
> 
> Please pull this series if you are ok with that patch. Otherwise I'll respin
> entire series.

I'll wait for the dust to settle here before submitting an ARM return
insn fix, and aarch64 support originally authored by Chris Ryder
(basically translate table in [1] into regex format).

Thanks,

Kim

[1] https://lkml.org/lkml/2016/5/19/461

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes  for ARM Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:40 +0200
  Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes  for ARM Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-10-10 15:50 +0200
    Re: [PATCH v7 6/6] perf annotate: cross arch annotate support fixes  for ARM Kim Phillips <kim.phillips@arm.com> - 2016-10-10 18:00 +0200

csiph-web