Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1497774

Re: [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state
Date 2016-10-08 18:40 +0200
Message-ID <sq2Pf-Xc-9@gated-at.bofh.it> (permalink)
References <spYBX-6SZ-3@gated-at.bofh.it> <spYBX-6SZ-5@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sat, Oct 08, 2016 at 02:59:36PM +0300, Tomas Winkler wrote:
> From: "Winkler, Tomas" <tomas.winkler@intel.com>
> 
> The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady for
> SW to indicate that the device can enter or should exit the idle state.
> 
> The legacy ACPI-start (SMI + DMA) based devices do not support these
> bits and the idle state management is not exposed to the host SW.
> Thus, this functionality only is enabled only for a CRB start (MMIO)
> based devices.
> 
> Based on Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> original patch:
> 'tpm_crb: implement power tpm crb power management'
> 
> To keep the implementation local to the hw we don't use wait_for_tpm_stat
> for polling the TPM_CRB_CTRL_REQ.

I just realized that the HW specific argument does not hold at all.  The
tpm_tis_core heavily uses wait_for_tpm_stat and return value of status
is synthetized.

It's upper layer for FIFO implemetations but still the arguement still
holds.

Lets keep it the way it is for now because this is fairly well test but
I might consider sending patch  that migrates to wait_for_tpm_stat unless
there is no real reason not to do so.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/4] tpm/tpm_crb: implement power management. Tomas Winkler <tomas.winkler@intel.com> - 2016-10-08 14:10 +0200
  [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Tomas Winkler <tomas.winkler@intel.com> - 2016-10-08 14:10 +0200
    Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 14:50 +0200
      RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 15:40 +0200
        Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 18:10 +0200
          RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 20:20 +0200
            Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 20:50 +0200
  [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state Tomas Winkler <tomas.winkler@intel.com> - 2016-10-08 14:10 +0200
    Re: [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 18:40 +0200
  [PATCH 3/4] tpm/tpm_crb: open code the crb_init into acpi_add Tomas Winkler <tomas.winkler@intel.com> - 2016-10-08 14:10 +0200
  [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Tomas Winkler <tomas.winkler@intel.com> - 2016-10-08 14:10 +0200
    Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 15:00 +0200
      RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 16:30 +0200
        Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 18:10 +0200
          Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-08 18:50 +0200
            RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 19:00 +0200
            Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 19:10 +0200
          RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 19:00 +0200
            Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 19:10 +0200
              RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 19:30 +0200
                RE: [tpmdd-devel] [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug         during idle state "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-10-08 21:00 +0200

csiph-web