Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1497752

Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

From Wim Van Sebroeck <wim@iguana.be>
Newsgroups linux.kernel
Subject Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer
Date 2016-10-08 16:20 +0200
Message-ID <sq0DL-89G-9@gated-at.bofh.it> (permalink)
References <sgvSy-1oS-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Matt,

> Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from
> struct watchdog_device") removed the dev pointer from struct
> watchdog_device, but this driver was still assigning it, leading to a
> compilation error:
> 
> drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’:
> drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’
> has no member named ‘dev’
>   rt288x_wdt_dev.dev = &pdev->dev;
>                 ^
> scripts/Makefile.build:289: recipe for target
> 'drivers/watchdog/rt2880_wdt.o' failed
> 
> Fix this by removing the assignment.
> 
> Fixes: 0254e953537c
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
> ---

This patch and a similar patch from Guenter regarding mt7621_wdt was
added to linux-watchdog-next almost 2 weeks ago.

Kind regards,
Wim.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer Wim Van Sebroeck <wim@iguana.be> - 2016-10-08 16:20 +0200

csiph-web