Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs
Date	2016-10-07 10:10 +0200
Message-ID	<spyoa-5NZ-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <sowRr-2BB-1@gated-at.bofh.it> <sozcB-47o-21@gated-at.bofh.it> <soX5f-3e7-5@gated-at.bofh.it> <spiMp-20b-3@gated-at.bofh.it> <spx8J-4I5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 7 Oct 2016, Jiri Olsa wrote:
> On Thu, Oct 06, 2016 at 11:25:43AM -0400, Prarit Bhargava wrote:
> > I thought about doing this but it seems like every time some driver uses
> > topology_logical_package_id() the driver would have to replicate the error
> > checking code.
> 
> hm, unless we guarantee topology_logical_package_id always
> returns sane values I dont see another way

I did some deeper investigation. So with prarits patch there is only one
possibility left to end up with an empty package id:

SMP Kernel on UP Machine, which has neither ACPI nor MADT. But those
machines are not a problem because they don't use any drivers which would
make use of it. Aside of that for UP we just can set the node of the cpu to
0 and be done with it. I'll pick up Prarits patch and amend it.

Thanks,

	tglx

Thread

[PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Prarit Bhargava <prarit@redhat.com> - 2016-10-03 19:10 +0200
  Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Jiri Olsa <jolsa@redhat.com> - 2016-10-04 00:30 +0200
  Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded  CPUs Thomas Gleixner <tglx@linutronix.de> - 2016-10-04 13:10 +0200
    Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Prarit Bhargava <prarit@redhat.com> - 2016-10-04 14:20 +0200
      Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded  CPUs Thomas Gleixner <tglx@linutronix.de> - 2016-10-04 16:50 +0200
        Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Prarit Bhargava <prarit@redhat.com> - 2016-10-04 18:10 +0200
        Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Jiri Olsa <jolsa@redhat.com> - 2016-10-05 18:20 +0200
          Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Prarit Bhargava <prarit@redhat.com> - 2016-10-06 17:30 +0200
            Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Jiri Olsa <jolsa@redhat.com> - 2016-10-07 08:50 +0200
              Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded  CPUs Thomas Gleixner <tglx@linutronix.de> - 2016-10-07 10:10 +0200
    Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs Jiri Olsa <jolsa@redhat.com> - 2016-10-04 14:30 +0200
      Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded  CPUs Thomas Gleixner <tglx@linutronix.de> - 2016-10-04 16:30 +0200
  [tip:x86/urgent] arch/x86: Handle non enumerated CPU after physical  hotplug tip-bot for Prarit Bhargava <tipbot@zytor.com> - 2016-10-07 15:30 +0200

csiph-web