Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1496961

Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
Date 2016-10-07 03:20 +0200
Message-ID <sprZo-Id-15@gated-at.bofh.it> (permalink)
References <spi9I-1qA-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  6 Oct 2016 16:44:53 +0200

> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `emac_probe':
>     emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
>     drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
> 
> If NO_IOMEM=y:
> 
>     drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
>     drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>        iounmap(adpt->phy.digital);
>        ^
> 
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:50 +0200
  Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on  HAS_DMA and HAS_IOMEM David Miller <davem@davemloft.net> - 2016-10-07 03:20 +0200

csiph-web