Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496880

Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"
Date 2016-10-07 00:10 +0200
Message-ID <spp1v-72A-25@gated-at.bofh.it> (permalink)
References <spoyt-6y4-7@gated-at.bofh.it> <spoyt-6y4-5@gated-at.bofh.it> <spoI9-6CY-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 06, 2016 at 05:41:34PM -0400, Sinan Kaya wrote:
> On 10/6/2016 5:37 PM, Al Viro wrote:
> > On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote:
> >> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or
> >> negative") as it breaks the debugfs_remove_recursive API as show in the
> >> callstack below.
> > 
> > NAK.  Fix your code, don't break global asserts.
> > 
> 
> I can fix the code if you tell me what the problem is:

Getting dentries with NULL ->d_parent should never, ever happen.  Find the
place where such a beast appears and you've got your problem.

The same goes for negative dentries with children.  Again, if your code
triggers such a situation, find where it does so and you've found a bug.
More than one, at that.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-06 23:40 +0200
  Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya <okaya@codeaurora.org> - 2016-10-06 23:50 +0200
    Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya <okaya@codeaurora.org> - 2016-10-07 00:00 +0200
      Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya <okaya@codeaurora.org> - 2016-10-07 00:20 +0200
    Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-07 00:10 +0200
      Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-07 00:40 +0200
        Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-07 00:50 +0200
          Re: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya <okaya@codeaurora.org> - 2016-10-07 01:30 +0200

csiph-web