Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status()

From	Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status()
Date	2016-10-06 21:20 +0200
Message-ID	<spmmZ-57E-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <spdjI-6HB-29@gated-at.bofh.it> <spjSa-2Un-39@gated-at.bofh.it> <spkuR-3vj-3@gated-at.bofh.it> <spkOd-3Hh-25@gated-at.bofh.it> <spl7A-3RX-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi all!

On Thu, 2016-10-06 at 19:49 +0200, SF Markus Elfring wrote:
> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> > > > []
> > > > > 
> > > > > @@ -7044,7 +7044,7 @@ static void raid5_status(struct
> > > > > seq_file *seq, struct mddev *mddev)
> > > > >  			   rdev && test_bit(In_sync, &rdev-
> > > > > >flags) ? "U" : "_");
> > > > >  	}
> > > > >  	rcu_read_unlock();
> > > > > -	seq_printf (seq, "]");
> > > > > +	seq_puts(seq, "]");
> > > > seq_putc
> > > How do you think about the possibility that the script
> > > "checkpatch.pl" can also point
> > > such a source code transformation out directly?
> > 
> > Why don't _you_ try to implement that in checkpatch instead?
> 
> How are the chances that any other software developer would be
> quicker (than me) for such
> an addition because of more practical knowledge for the programming
> language "Perl"?

The above is BTW a pretty simple thing and thus good for a learning
experience for regular expressions and copy-pasting a few lines in that
perl-script and editing them.

MfG,
	Bernd

PS: Sry for the noise - it's somewhat OT here ....
-- 
Bernd Petrovitsch                  Email : bernd@petrovitsch.priv.at
                     LUGA : http://www.luga.at

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in  raid5_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-06 11:40 +0200
  Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by  seq_puts() in raid5_status() Joe Perches <coupons@perches.com> - 2016-10-06 18:40 +0200
    Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts()  in raid5_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-06 19:20 +0200
      Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by  seq_puts() in raid5_status() Joe Perches <joe@perches.com> - 2016-10-06 19:40 +0200
        Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts()  in raid5_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-06 20:00 +0200
          Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by  seq_puts() in raid5_status() Joe Perches <joe@perches.com> - 2016-10-06 20:00 +0200
            Re: md/raid5: Replace a seq_printf() call by seq_puts() in  raid5_status() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-06 20:30 +0200
          Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by  seq_puts() in raid5_status() Bernd Petrovitsch <bernd@petrovitsch.priv.at> - 2016-10-06 21:20 +0200

csiph-web