Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1496554

[PATCH net 11/13] afs: Check for fatal error when in waiting for ack state

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject [PATCH net 11/13] afs: Check for fatal error when in waiting for ack state
Date 2016-10-06 12:10 +0200
Message-ID <spdMJ-79a-7@gated-at.bofh.it> (permalink)
References <spdMJ-79a-3@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


When it's in the waiting-for-ACK state, the AFS filesystem needs to check
the result of rxrpc_kernel_recv_data() any time it is notified to see if it
is indicating a fatal error.  If this is the case, it needs to mark the
call completed otherwise the call just sits there and never goes away.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/rxrpc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
index 59bdaa7527b6..477928b25940 100644
--- a/fs/afs/rxrpc.c
+++ b/fs/afs/rxrpc.c
@@ -418,7 +418,7 @@ static void afs_deliver_to_call(struct afs_call *call)
 						     &call->abort_code);
 			if (ret == -EINPROGRESS || ret == -EAGAIN)
 				return;
-			if (ret == 1) {
+			if (ret == 1 || ret < 0) {
 				call->state = AFS_CALL_COMPLETE;
 				goto done;
 			}

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH net 11/13] afs: Check for fatal error when in waiting for  ack state David Howells <dhowells@redhat.com> - 2016-10-06 12:10 +0200

csiph-web