Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496203

Re: [GIT PULL] overlayfs update for 4.9

Show all headers | View raw

On Thu, Oct 6, 2016 at 1:49 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Oct 05, 2016 at 09:52:10PM +0200, Miklos Szeredi wrote:
>> Hi Al,
>>
>> Please pull from:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-viro
>>
>> This has an assortment of fixes and cleanups for overlayfs.
>>
>> It also touches the VFS:
>>
>>  - add the vfs_get_link() helper for calling i_op->get_link();
>>  - fix mnt_want_write_file() to freeze protect the underlying sb instead of
>>    overlay sb;
>>  - allow vfs_clone_file_range() to be called by overlayfs.
>
> Could you explain why e.g. fsetxattr() needs a different treatment in
> "vfs: mnt_want_write_file() should freeze protect underlying sb"?

Because setxattr is an i_op, not a f_op, so it's overlayfs that's
going to be called and will do the freeze protect on underlying layer
(not to mention, that it might be a different underlying sb that will
get the freeze protection in the end, due to copy up)

Thanks,
Miklos

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] overlayfs update for 4.9 Miklos Szeredi <miklos@szeredi.hu> - 2016-10-05 22:00 +0200
  Re: [GIT PULL] overlayfs update for 4.9 Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-05 22:10 +0200
  Re: [GIT PULL] overlayfs update for 4.9 Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-06 01:50 +0200
    Re: [GIT PULL] overlayfs update for 4.9 Miklos Szeredi <miklos@szeredi.hu> - 2016-10-06 10:10 +0200
      Re: [GIT PULL] overlayfs update for 4.9 Miklos Szeredi <miklos@szeredi.hu> - 2016-10-11 22:10 +0200

csiph-web