Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1497708
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array |
| Date | 2016-10-08 13:10 +0200 |
| Message-ID | <spXFT-6jD-5@gated-at.bofh.it> (permalink) |
| References | <sny8V-4tY-3@gated-at.bofh.it> <sny8V-4tY-1@gated-at.bofh.it> <snWuB-3G8-7@gated-at.bofh.it> <soaxA-4S2-5@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Mon, Oct 03, 2016 at 03:21:35PM +0300, Jarkko Sakkinen wrote:
> On Sun, Oct 02, 2016 at 03:28:01PM -0600, Jason Gunthorpe wrote:
> > On Sat, Oct 01, 2016 at 10:25:25PM +0300, Jarkko Sakkinen wrote:
> >
> > > + for (i = (TPM_NUM_EVENT_LOG_FILES - 1); i >= 0; i--) {
> > > + if (chip->bios_dir[i])
> >
> > The entries can't actually be null here, right?
>
> They can because this function is called as a rollbcak procedure for
> tpm_bios_log_setup.
I've tested these with Dell E6400 laptop and IvyBridge NUC both with TPM
1.2 chip by repeating this a few iterations:
1. modprobe tpm_tis
2. Outputted sysfs attributes
3. Outputted measurement files.
4. rmmod tpm_tis
I think these three commits could be applied at any point and would help
with the event log series (shrunk it a bit).
/Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RESEND 0/3] Clean up handling of event log files Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-01 21:30 +0200
[PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-01 21:30 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-02 23:30 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-03 14:30 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 13:10 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Nayna <nayna@linux.vnet.ibm.com> - 2016-10-10 21:00 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-11 13:30 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Nayna <nayna@linux.vnet.ibm.com> - 2016-10-11 19:30 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-11 20:20 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-10-11 19:40 +0200
Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-11 20:20 +0200
[PATCH RESEND 3/3] tpm: drop tpm1_chip_register(/unregister) Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-01 21:30 +0200
[PATCH RESEND 1/3] tpm: define a generic open() method for ascii & bios measurements Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-01 21:30 +0200
Re: [PATCH RESEND 1/3] tpm: define a generic open() method for ascii & bios measurements Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-10-08 13:10 +0200
csiph-web