Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1497670
| From | Yinghai Lu <yinghai@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [tip:x86/urgent] x86/acpi: Prevent LAPIC id 0xff from being accounted |
| Date | 2016-10-08 07:40 +0200 |
| Message-ID | <spSwx-2VS-1@gated-at.bofh.it> (permalink) |
| References | <spSmS-2SF-7@gated-at.bofh.it> <spSmS-2SF-5@gated-at.bofh.it> <spSwx-2VS-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Oct 7, 2016 at 10:33 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Fri, Oct 7, 2016 at 10:26 PM, Yinghai Lu <yinghai@kernel.org> wrote: >> On Fri, Oct 7, 2016 at 6:28 AM, tip-bot for Thomas Gleixner >>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c >>> index 32a7d70..6d35baf 100644 >>> --- a/arch/x86/kernel/acpi/boot.c >>> +++ b/arch/x86/kernel/acpi/boot.c >>> @@ -233,6 +233,9 @@ acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end) >>> >>> acpi_table_print_madt_entry(header); >>> >>> + if (processor->id >= 0xff) >>> + return -EINVAL; >>> + >>> /* >>> * We need to register disabled CPU as well to permit >>> * counting disabled CPUs. This allows us to size >> >> >> some thing is wrong: >> >> [ 71.787437] ACPI: LAPIC (acpi_id[0xff] lapic_id[0xff] disabled) >> [ 71.799681] ACPI: Error parsing LAPIC/X2APIC entries >> [ 71.809934] ACPI: Invalid BIOS MADT, disabling ACPI >> >> looks like should change >> return -EINVAL ; >> ==> >> return 0; > > also processor->id is u8, > > so the patch should be: + if (processor->id == 0xff) + return 0; +
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [tip:x86/urgent] x86/acpi: Prevent LAPIC id 0xff from being accounted Yinghai Lu <yinghai@kernel.org> - 2016-10-08 07:30 +0200
Re: [tip:x86/urgent] x86/acpi: Prevent LAPIC id 0xff from being accounted Yinghai Lu <yinghai@kernel.org> - 2016-10-08 07:40 +0200
Re: [tip:x86/urgent] x86/acpi: Prevent LAPIC id 0xff from being accounted Thomas Gleixner <tglx@linutronix.de> - 2016-10-08 12:20 +0200
Re: [tip:x86/urgent] x86/acpi: Prevent LAPIC id 0xff from being accounted Yinghai Lu <yinghai@kernel.org> - 2016-10-08 07:40 +0200
csiph-web