Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document

From	Joshua Clayton <stillcompiling@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document
Date	2016-10-07 22:50 +0200
Message-ID	<spKfD-5J5-5@gated-at.bofh.it> (permalink)
References	<spnCq-5Wo-9@gated-at.bofh.it> <spnCq-5Wo-5@gated-at.bofh.it> <spnCq-5Wo-3@gated-at.bofh.it> <sptya-1OK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Moritz,

thank you very much for the review.
 
On 10/06/2016 07:53 PM, Moritz Fischer wrote:
> Hi Joshua,
>
> On Thu, Oct 6, 2016 at 1:34 PM, Joshua Clayton <stillcompiling@gmail.com> wrote:
>> Describe a cyclonespi devicetree entry, required features
>>
>> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
>> ---
>>  .../bindings/fpga/cyclone-spi-fpga-mgr.txt         | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt
>> new file mode 100644
>> index 0000000..8de34db
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fpga/cyclone-spi-fpga-mgr.txt
>> @@ -0,0 +1,23 @@
>> +Altera SOCFPGA FPGA Manager
> Copy & Paste? :)
Oops :(
As you might image, documentation was the last item done with the least attention.
Will fix.
>
>> +Altera cyclone FPGAs support a method of loading the bitstream over what is
> cyclone->Cyclone
OK.
>> +referred to as "passive serial".
>> +The passive serial link is not technically spi, and might require extra
>> +circuits in order to play nicely with other spi slaves on the same bus.
>> +
>> +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf
>> +
>> +Required properties:
>> +- compatible  : should contain "altr,cyclonespi-fpga-mgr"
> Alan, do you guys have any input on the compat string?
I am open to change if it makes sense. I tried to keep the format similar.
> I think generally the bindings should go before the actual usage in
> your patch series. Meaning you wanna document the binding
> before you use it. I think this patch should be [1/3].
Ah, In my mind I had it backwards.
> Cheers,
>
> Moritz
I'll give Alan a chance to review and then spin a V2

Joshua Clayton

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] doc: dt: add cyclone-spi binding document Joshua Clayton <stillcompiling@gmail.com> - 2016-10-06 22:40 +0200
  Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document Moritz Fischer <moritz.fischer@ettus.com> - 2016-10-07 05:00 +0200
    Re: [PATCH 2/3] doc: dt: add cyclone-spi binding document Joshua Clayton <stillcompiling@gmail.com> - 2016-10-07 22:50 +0200

csiph-web