Re: [PATCH] net: Reset skb to network header in neigh_hh_output

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: Reset skb to network header in neigh_hh_output
Date	2016-10-07 23:20 +0200
Message-ID	<spKIG-69y-23@gated-at.bofh.it> (permalink)
References	<spEad-1y8-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-10-07 at 16:14 +0200, Abdelrhman Ahmed wrote:
> When hardware header is added without using cached one, neigh_resolve_output
> and neigh_connected_output reset skb to network header before adding it.
> When cached one is used, neigh_hh_output does not reset the skb to network
> header.
> 
> The fix is to reset skb to network header before adding cached hardware header
> to keep the behavior consistent in all cases.

What is the issue you want to fix exactly ?

Please describe the use case.

I highly suggest you take a look at commit

e1f165032c8bade3a6bdf546f8faf61fda4dd01c
("net: Fix skb_under_panic oops in neigh_resolve_output")

Otherwise, your fix is in fact adding a critical bug.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: Reset skb to network header in neigh_hh_output Abdelrhman Ahmed <ab@abahmed.com> - 2016-10-07 16:20 +0200
  Re: [PATCH] net: Reset skb to network header in neigh_hh_output Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-10-07 18:30 +0200
    Re: [PATCH] net: Reset skb to network header in neigh_hh_output Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-10-07 18:40 +0200
  Re: [PATCH] net: Reset skb to network header in neigh_hh_output Eric Dumazet <eric.dumazet@gmail.com> - 2016-10-07 23:20 +0200

csiph-web