Re: [GIT PULL] trivial for 4.9

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] trivial for 4.9
Date	2016-10-07 22:30 +0200
Message-ID	<spJWi-5BJ-5@gated-at.bofh.it> (permalink)
References	<spzax-6ev-11@gated-at.bofh.it> <spJ0d-4VA-5@gated-at.bofh.it> <spJCW-5r1-15@gated-at.bofh.it> <spJMC-5yb-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-10-07 at 13:13 -0700, Linus Torvalds wrote:
> On Fri, Oct 7, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
> > Any printk without a KERN_<level> prefix, and there
> > are still many of those, can cause random interleaving.
> How about people actually work on *that* instead of working around it?
> Because the above really should not be true.
> > Not at all.  Until printk KERN_<level> uses are mandated,
> > then these newlines are still useful.
> The patches literally added those '\n' things to the pr_xyz() routines
> that *enforce* KERN_<level>.

No, because any of those can be followed by a bare printk
or a pr_cont that continues the original line.

> So really. It's a step backwards. We shouldn't need them. We should
> *remove* '\n' at the end, and then if that actually causes problems,
> we should fix those problems.

$ git grep -w printk * | grep -v "^tools" | grep -v KERN | wc -l
13176

Have at it but here are _far_ fewer missing newlines
and it'd be much lower churn to fix those than remove
all the newlines and fix the missing continuations.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] trivial for 4.9 Jiri Kosina <jikos@kernel.org> - 2016-10-07 11:00 +0200
  Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-07 21:30 +0200
    Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-07 22:10 +0200
      Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-07 22:20 +0200
        Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-07 22:30 +0200
          Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-07 22:40 +0200
            Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-07 23:10 +0200
              Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-07 23:40 +0200
                Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-08 09:40 +0200
                Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-10 07:50 +0200
              Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-07 23:50 +0200
                Re: [GIT PULL] trivial for 4.9 Tony Luck <tony.luck@gmail.com> - 2016-10-08 01:10 +0200
                Re: [GIT PULL] trivial for 4.9 Tony Luck <tony.luck@gmail.com> - 2016-10-08 01:20 +0200
                Re: [GIT PULL] trivial for 4.9 Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-08 01:40 +0200
                Re: [GIT PULL] trivial for 4.9 Steven Rostedt <rostedt@goodmis.org> - 2016-10-08 15:30 +0200
        Re: [GIT PULL] trivial for 4.9 Joe Perches <joe@perches.com> - 2016-10-07 22:30 +0200

csiph-web