Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h
Date	2016-10-07 17:40 +0200
Message-ID	<spFpE-2pN-75@gated-at.bofh.it> (permalink)
References	<spF6i-2hj-41@gated-at.bofh.it> <spFfY-2lv-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote:
> From: Rajat Jain <rajatjain@juniper.net>
> 
> Add this header to contain the PCI device IDs that we cannot add in
> the linux pci_ids.h.

Why can't you?

> This would contain PCI device IDs of Juniper devices as well as any
> PCIe switches etc.

Why do you need a .h file for this?  Is the values in it shared across
drivers?  If not, you don't nee a .h file at all.  If so, then it
belongs in pci_ids.h as the top of that file describes.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h Pantelis Antoniou <pantelis.antoniou@konsulko.com> - 2016-10-07 17:30 +0200
  Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-07 17:40 +0200

csiph-web