Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1497156

Re: md-cluster: Delete unnecessary braces in unlock_all_bitmaps()

Show all headers | View raw

Am 07.10.2016 10:37, schrieb SF Markus Elfring:
>>> Do not use curly brackets at one source code place
>>> where a single statement should be sufficient.
>>
>> The original style was correct and this is wrong.  I have explained this before.
> 
> Did I change a bit too much in the proposed step according to the following
> update suggestion?
> 
> elfring@Sonne:~/Projekte/Linux/next-patched> git checkout d6385db94196b253ae5eb3678fa95cdf1f839fcc && scripts/checkpatch.pl --types BRACES -f drivers/md/md-cluster.c
> …
> WARNING: braces {} are not necessary for single statement blocks
> #1228: FILE: drivers/md/md-cluster.c:1228:
> +			if (cinfo->other_bitmap_lockres[i]) {
> +				lockres_free(cinfo->other_bitmap_lockres[i]);
> +			}
> …
> 
> 
> How do you think about to adjust this source code place a bit?
> 

perhaps we can agree to delete the if() block ?

static void lockres_free(struct dlm_lock_resource *res)
{
        int ret;

       if (!res)
                return;

....


@marcus: is can not send mail to you sf.net adresse because sf.net
         mark my domain als spam (note: nobody else does)

re,
 wh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] md-cluster: Fine-tuning for ten function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 16:50 +0200
  [PATCH 01/15] md-cluster: Use kcalloc() in lock_all_bitmaps() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 16:50 +0200
  [PATCH 04/15] md-cluster: Improve another size determination in  __sendmsg() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 16:50 +0200
  [PATCH 02/15] md-cluster: Improve another size determination in  resync_info_update() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 16:50 +0200
  [PATCH 03/15] md-cluster: Improve another size determination in  join() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 16:50 +0200
  [PATCH 10/15] md-cluster: Delete an unnecessary variable  initialisation in lockres_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 12/15] md-cluster: Rename a jump label in area_resyncing() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 13/15] md-cluster: Less function calls in join() after error  detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
    [PATCH v2 13/15] md-cluster: Less function calls in join() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-06 17:20 +0200
  [PATCH 05/15] md-cluster: Improve another size determination in  recv_daemon() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 07/15] md-cluster: Improve another size determination in  process_suspend_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 14/15] md-cluster: Less function calls in lockres_init() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 11/15] md-cluster: Delete four error messages for a failed  memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 08/15] md-cluster: Improve determination of sizes in  read_resync_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 09/15] md-cluster: Improve another size determination in  lockres_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 06/15] md-cluster: Rename a jump label in recv_daemon() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:00 +0200
  [PATCH 15/15] md-cluster: Delete unnecessary braces in  unlock_all_bitmaps() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-01 17:10 +0200
    Re: [PATCH 15/15] md-cluster: Delete unnecessary braces in  unlock_all_bitmaps() Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-07 09:50 +0200
      Re: md-cluster: Delete unnecessary braces in unlock_all_bitmaps() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-07 10:40 +0200
        Re: md-cluster: Delete unnecessary braces in unlock_all_bitmaps() walter harms <wharms@bfs.de> - 2016-10-07 15:30 +0200

csiph-web