Re: [patch 12/32] greybus: es2 host driver

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [patch 12/32] greybus: es2 host driver
Date	2016-10-07 15:50 +0200
Message-ID	<spDHc-161-13@gated-at.bofh.it> (permalink)
References	<shfsm-830-21@gated-at.bofh.it> <shV8d-14L-5@gated-at.bofh.it> <si1nj-5f0-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri 2016-09-16 15:25:25, Greg KH wrote:
> This is a Greybus host driver for the ES2/3 bridge chip from Toshiba.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

> +/*
> + * @endpoint: bulk in endpoint for CPort data
> + * @urb: array of urbs for the CPort in messages
> + * @buffer: array of buffers for the @cport_in_urb urbs
> + */
> +struct es2_cport_in {
> +	__u8 endpoint;
> +	struct urb *urb[NUM_CPORT_IN_URB];
> +	u8 *buffer[NUM_CPORT_IN_URB];

Underscored versions of __u8 and friends are unneccessary here... as
shown later in the struct. Makes sense to fix in whole file.
								pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [patch 12/32] greybus: es2 host driver Pavel Machek <pavel@ucw.cz> - 2016-10-07 15:50 +0200

csiph-web