Re: [GIT] Networking

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: [GIT] Networking
Date	2016-10-06 03:00 +0200
Message-ID	<sp5ct-17c-5@gated-at.bofh.it> (permalink)
References	<soNfz-4TI-3@gated-at.bofh.it> <sp30Z-8gt-3@gated-at.bofh.it> <sp30Z-8gt-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

On Wed, 5 Oct 2016 15:37:17 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Wed, Oct 5, 2016 at 3:29 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > I have been carrying the following merge fix patch (for the merge of
> > the net-next tree with Linus' tree) for a while now which seems to have
> > got missed:  
> 
> Ugh. It doesn't seem to be a merge error, because that double iph
> assignment came from the original patch that introduced this function:
> commit ddc8b6027ad0 ("netfilter: introduce nft_set_pktinfo_{ipv4,
> ipv6}_validate()").

Except that commit effectively moved that function from
net/netfilter/nf_tables_netdev.c to
include/net/netfilter/nf_tables_ipv4.h while commit c73c24849011
("netfilter: nf_tables_netdev: remove redundant ip_hdr assignment")
removed the assignment in the original file (and has been in your tree
since v4.8-rc7) and that is where I originally actually got a conflict.

> So I wouldn't call it a merge error - it just looks like a bug in the
> network layer. So I'm not going to apply your patch even though it
> looks plausible to me, simply because it's outside my area of
> expertise.

no worries.
-- 
Cheers,
Stephen Rothwell

Thread

Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-06 00:40 +0200
  Re: [GIT] Networking Pablo Neira Ayuso <pablo@netfilter.org> - 2016-10-06 02:20 +0200
    Re: [GIT] Networking David Miller <davem@davemloft.net> - 2016-10-06 02:30 +0200
  Re: [GIT] Networking Stephen Rothwell <sfr@canb.auug.org.au> - 2016-10-06 03:00 +0200
    Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-06 04:20 +0200
      Re: [GIT] Networking David Miller <davem@davemloft.net> - 2016-10-06 05:00 +0200
        Re: [GIT] Networking Stephen Rothwell <sfr@canb.auug.org.au> - 2016-10-06 07:10 +0200
      Re: [GIT] Networking Stephen Rothwell <sfr@canb.auug.org.au> - 2016-10-06 05:00 +0200

csiph-web