Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values

From	Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups	linux.kernel
Subject	Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values
Date	2016-10-06 00:00 +0200
Message-ID	<sp2om-7M2-5@gated-at.bofh.it> (permalink)
References	<soWsx-2L8-15@gated-at.bofh.it> <soWsx-2L8-23@gated-at.bofh.it> <sp2eD-7H9-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 05, 2016 at 06:44:04PM -0300, Paulo Zanoni wrote:
> Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index dd15ae2..c580d3d 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -3378,6 +3378,8 @@ static void skylake_update_primary_plane(struct
> > drm_plane *plane,
> >  	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state-
> > >base.crtc);
> >  	struct drm_framebuffer *fb = plane_state->base.fb;
> >  	const struct skl_wm_values *wm = &dev_priv->wm.skl_results;
> > +	const struct skl_plane_wm *p_wm =
> > +		&crtc_state->wm.skl.optimal.planes[0];
> 
> I wish someone would do a patch to convert all these hardcoded values
> to PLANE_X, and convert "int"s  to "enum plane"s everywhere.

Note that this is not PLANE_A, but setting up a shorthand local for

	const struct skl_plane_wm *p_wm = crtc_state->wm.skl.optimal.planes;

-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Thread

[PATCH 0/6] Start of skl watermark cleanup Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
  [PATCH 2/6] drm/i915/skl: Remove linetime from skl_wm_values Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
    Re: [Intel-gfx] [PATCH 2/6] drm/i915/skl: Remove linetime from  skl_wm_values Paulo Zanoni <paulo.r.zanoni@intel.com> - 2016-10-05 22:30 +0200
  [PATCH 1/6] drm/i915/skl: Move per-pipe ddb allocations into crtc states Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
    Re: [Intel-gfx] [PATCH 1/6] drm/i915/skl: Move per-pipe ddb  allocations into crtc states Paulo Zanoni <paulo.r.zanoni@intel.com> - 2016-10-05 22:30 +0200
  [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
    Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant  watermark values Paulo Zanoni <paulo.r.zanoni@intel.com> - 2016-10-05 23:50 +0200
      Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant  watermark values Chris Wilson <chris@chris-wilson.co.uk> - 2016-10-06 00:00 +0200
  [PATCH 6/6] drm/i915/gen9: Add ddb changes to atomic debug output Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
  [PATCH 3/6] drm/i915: Add enable_sagv option Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
    Re: [Intel-gfx] [PATCH 3/6] drm/i915: Add enable_sagv option Paulo Zanoni <paulo.r.zanoni@intel.com> - 2016-10-05 21:40 +0200
  [PATCH 4/6] drm/i915/gen9: Make skl_wm_level per-plane Lyude <cpaul@redhat.com> - 2016-10-05 17:40 +0200
    Re: [Intel-gfx] [PATCH 4/6] drm/i915/gen9: Make skl_wm_level  per-plane Paulo Zanoni <paulo.r.zanoni@intel.com> - 2016-10-05 22:40 +0200
      Re: [Intel-gfx] [PATCH 4/6] drm/i915/gen9: Make skl_wm_level  per-plane Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-10-06 12:40 +0200
  Re: [PATCH 0/6] Start of skl watermark cleanup Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-10-06 13:30 +0200

csiph-web