Re: [PATCH v5 1/5] firmware: document user mode helper lock usage

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/5] firmware: document user mode helper lock usage
Date	2016-10-05 22:50 +0200
Message-ID	<sp1ix-6VP-9@gated-at.bofh.it> (permalink)
References	<sfsWJ-2Il-1@gated-at.bofh.it> <sfsWJ-2Il-9@gated-at.bofh.it> <sfCjn-gb-15@gated-at.bofh.it> <sk25z-tK-11@gated-at.bofh.it> <sp1ix-6VP-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 23, 2016 at 10:13:44AM +0200, Daniel Wagner wrote:
> On 09/22/2016 04:36 AM, Ming Lei wrote:
> >On Sat, Sep 10, 2016 at 6:14 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> >>On Fri, Sep 09, 2016 at 02:12:20PM +0200, Daniel Wagner wrote:
> >>>From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >>>
> >>>The lock is also used to generate warnings when a direct
> >>>firmware load is requested too early.
> >>
> >>I've determined the firmware cache lets us bail out of this
> >>consideration now. If Ming agrees with the logic we don't need this
> >>patch and you can continue as you had intended. Sorry for the trouble.
> >
> >IMO it is helpful to add comment about using the lock for direct loading,
> >and we can sort it out in future if anyone want to improve it.
> >
> >So for this patch, I am fine.
> 
> Sorry, I am a bit confused now. What is the consensus here:
> 
>  a) add a comment to _request_firmware() as in this patch #1 v5

The adding a comment note from Daniel was that the UMH lock is *not*
needed on the direct firmware loading case, he's lazy to remove it
now so he'll just add a comment.

>  b) move the umh locking to fw_load_from_user_helper() as in
>     patch #1 v4

This is fine and IMHO the non-lazy approach.

To be clear -- I did my own vetting of the removal of the lock by
inspecting the original purpose of the UMH lock being added on the
history Linux git tree, having a secondary review of that would be
appreciated as well.

  Luis

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/5] firmware: document user mode helper lock usage "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-10-05 22:50 +0200
  Re: [PATCH v5 1/5] firmware: document user mode helper lock usage "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-10-10 20:50 +0200

csiph-web