Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495250

Re: [PATCH] x86: suppress sparse warning in copy_to_user()

Show all headers | View raw

>>> On 04.10.16 at 09:33, <johannes@sipsolutions.net> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> __compiletime_object_size() is simply defined to __builtin_object_size()
> which gcc declares with (void *, int type) prototype.

If that was the case, everyone should have seen such warnings from
the day the original patch got introduced. And the compiler warnings
I get when testing with all four combinations of const and volatile also
supports this by saying "expected 'const void *' but ..." (arguably the
compiler should accept volatile here too). To be honest, for code in
other trees where I'm maintainer, I'd reject such casting away of
constness, and demand the utility to get fixed instead.

Jan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: suppress sparse warning in copy_to_user() Johannes Berg <johannes@sipsolutions.net> - 2016-10-04 09:40 +0200
  Re: [PATCH] x86: suppress sparse warning in copy_to_user() "Jan Beulich" <JBeulich@suse.com> - 2016-10-04 10:00 +0200
    Re: [PATCH] x86: suppress sparse warning in copy_to_user() Johannes Berg <johannes@sipsolutions.net> - 2016-10-04 10:10 +0200
      Re: [PATCH] x86: suppress sparse warning in copy_to_user() "Jan Beulich" <JBeulich@suse.com> - 2016-10-04 10:40 +0200
        Re: [PATCH] x86: suppress sparse warning in copy_to_user() Johannes Berg <johannes@sipsolutions.net> - 2016-10-04 10:50 +0200
          Re: [PATCH] x86: suppress sparse warning in copy_to_user() "Jan Beulich" <JBeulich@suse.com> - 2016-10-04 11:10 +0200

csiph-web