Re: [PATCH] spmi: regmap: enable userspace writes

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spmi: regmap: enable userspace writes
Date	2016-10-03 23:10 +0200
Message-ID	<soiEO-1DF-15@gated-at.bofh.it> (permalink)
References	<smHR0-3wN-13@gated-at.bofh.it> <smNWq-7uF-19@gated-at.bofh.it> <smYf7-5TN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/30, kgunda@codeaurora.org wrote:
> On 2016-09-29 23:30, Mark Brown wrote:
> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> >
> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
> >
> >This is completely inappropriate for upstream, if you need to do
> >debugging on your platform you can enable this locally but enabling
> >random writes from userspace to any regmap device is really not a good
> >idea for system stablity or robustness.
> 
> Sure. I will remove this change and send the next version only to update
> the spmi device name.

Why? The device name looks fine.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] spmi: regmap: enable userspace writes Kiran Gunda <kgunda@codeaurora.org> - 2016-09-29 13:40 +0200
  Re: [PATCH] spmi: regmap: enable userspace writes Mark Brown <broonie@kernel.org> - 2016-09-29 20:10 +0200
    Re: [PATCH] spmi: regmap: enable userspace writes kgunda@codeaurora.org - 2016-09-30 07:10 +0200
      Re: [PATCH] spmi: regmap: enable userspace writes Stephen Boyd <sboyd@codeaurora.org> - 2016-10-03 23:10 +0200

csiph-web