Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1495032
| From | Michal Nazarewicz <mina86@mina86.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: BUG: scheduling while atomic in f_fs when gadget remove driver |
| Date | 2016-10-03 22:10 +0200 |
| Message-ID | <sohIK-123-35@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <slXuS-8bL-7@gated-at.bofh.it> <smjOG-537-11@gated-at.bofh.it> <smq3O-If-103@gated-at.bofh.it> <smuK6-3Ky-11@gated-at.bofh.it> <sogWl-uQ-13@gated-at.bofh.it> |
| Organization | http://mina86.com/ |
On Mon, Oct 03 2016, John Stultz wrote:
> On Wed, Sep 28, 2016 at 2:38 PM, Michal Nazarewicz <mina86@mina86.com> wrote:
>> On Wed, Sep 28 2016, Michal Nazarewicz wrote:
>>> With that done, the only thing which needs a mutex is
>>> epfile->read_buffer.
>>
>> Perhaps this would do:
>>
>> ---- >8 -------------------------------------------------- -------------
>> From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001
>> From: Michal Nazarewicz <mina86@mina86.com>
>> Date: Wed, 28 Sep 2016 23:36:56 +0200
>> Subject: [RFC] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> ffs_func_eps_disable is called from atomic context so it cannot sleep
>> thus cannot grab a mutex. Change the handling of epfile->read_buffer
>> to use non-sleeping synchronisation method.
>>
>> Reported-by: Chen Yu <chenyu56@huawei.com>
>> Signed-off-by: Michał Nazarewicz <mina86@mina86.com>
>> Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests")
>
> So the patch here seems to be in some odd encoding?
O_o
It’s UTF-8.
> Can you resend it using git-send-email or in some way other then
> embedding it inline here? Maybe just point me to a git tree that has
> it?
https://github.com/mina86/linux.git f-fs-fix
Regardless, I’ll prepare a proper patchset within a few days. Maybe
even now.
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
BUG: scheduling while atomic in f_fs when gadget remove driver Chen Yu <chenyu56@huawei.com> - 2016-09-27 11:50 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-09-27 12:10 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Chen Yu <chenyu56@huawei.com> - 2016-09-28 12:00 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Michal Nazarewicz <mina86@mina86.com> - 2016-09-28 18:40 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Michal Nazarewicz <mina86@mina86.com> - 2016-09-28 23:40 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Chen Yu <chenyu56@huawei.com> - 2016-09-30 04:00 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver John Stultz <john.stultz@linaro.org> - 2016-10-03 21:20 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver Michal Nazarewicz <mina86@mina86.com> - 2016-10-03 22:10 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver John Stultz <john.stultz@linaro.org> - 2016-10-03 22:20 +0200
Re: BUG: scheduling while atomic in f_fs when gadget remove driver John Stultz <john.stultz@linaro.org> - 2016-10-04 01:40 +0200
[PATCH 1/2] usb: gadget: f_fs: edit epfile->ep under lock Michal Nazarewicz <mina86@mina86.com> - 2016-10-04 02:10 +0200
[PATCH 2/2] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable Michal Nazarewicz <mina86@mina86.com> - 2016-10-04 02:10 +0200
Re: [PATCH 2/2] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable John Stultz <john.stultz@linaro.org> - 2016-10-04 02:30 +0200
Re: [PATCH 2/2] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable Chen Yu <chenyu56@huawei.com> - 2016-10-08 09:10 +0200
csiph-web