Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494963

Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

From Mike Looijmans <mike.looijmans@topic.nl>
Newsgroups linux.kernel
Subject Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode
Date 2016-10-03 18:40 +0200
Message-ID <soerv-7n1-29@gated-at.bofh.it> (permalink)
References <sobjX-5qH-1@gated-at.bofh.it> <soczo-68A-13@gated-at.bofh.it>
Organization Topic

Show all headers | View raw

On 03-10-16 16:35, Andrew Lunn wrote:
>> +    Boolean:
>> +
>> +      - enable-edpd : Not related to timing. Specify this property to enable
>> +                      energy-detect power-down mode in the PHY.
>
> The Broadcom PHYs unconditionally enable this feature.
>
> The SMSC driver has an option: smsc,disable-energy-detect because it
> seems to have a rare hardware bug when it is enabled.
>
> And you would like to make it off by default.
>
> Could we avoid having three drivers doing three different things?
> Could you have it unconditionally on, and see if anybody reports it
> being broken?

Good suggestion I think. It's a feature found on many PHYs, apparently 
without any ill effects, so just enabling unconditionally simplifies 
things. And it's good for the environment...

I'll post a v2 patch (which won't need devicetree changes then).

-- 
Mike Looijmans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode Mike Looijmans <mike.looijmans@topic.nl> - 2016-10-03 15:20 +0200
  Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down  mode Andrew Lunn <andrew@lunn.ch> - 2016-10-03 16:40 +0200
    Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down  mode Mike Looijmans <mike.looijmans@topic.nl> - 2016-10-03 18:40 +0200
  [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect power-down mode Mike Looijmans <mike.looijmans@topic.nl> - 2016-10-04 08:00 +0200
    Re: [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect  power-down mode Andrew Lunn <andrew@lunn.ch> - 2016-10-04 09:00 +0200
    Re: [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect power-down  mode Florian Fainelli <f.fainelli@gmail.com> - 2016-10-04 13:20 +0200
    Re: [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect  power-down mode David Miller <davem@davemloft.net> - 2016-10-06 03:40 +0200

csiph-web