Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495864

Re: [PATCH] watchdog: ath79_wdt: fix build failure

Show all headers | View raw

On 10/04/2016 10:28 PM, Sudip Mukherjee wrote:
> The build of mips ath79_defconfig was failing with the error:
> drivers/watchdog/ath79_wdt.c:164:5:
> 	error: implicit declaration of function 'get_user'
> drivers/watchdog/ath79_wdt.c:196:3:
> 	error: implicit declaration of function 'copy_to_user'
> drivers/watchdog/ath79_wdt.c:201:3:
> 	error: implicit declaration of function 'put_user'
>
> Quoting Al Viro - "another victim of indirect include chains"
>
> Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/164834126
>
>  drivers/watchdog/ath79_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/ath79_wdt.c b/drivers/watchdog/ath79_wdt.c
> index 835d310..e2209bf 100644
> --- a/drivers/watchdog/ath79_wdt.c
> +++ b/drivers/watchdog/ath79_wdt.c
> @@ -35,6 +35,7 @@
>  #include <linux/err.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> +#include <linux/uaccess.h>
>
>  #define DRIVER_NAME	"ath79-wdt"
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] watchdog: ath79_wdt: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-10-05 07:30 +0200
  Re: [PATCH] watchdog: ath79_wdt: fix build failure Guenter Roeck <linux@roeck-us.net> - 2016-10-05 15:20 +0200
  Re: [PATCH] watchdog: ath79_wdt: fix build failure Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-06 00:40 +0200

csiph-web