Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key
Date	2016-10-05 14:40 +0200
Message-ID	<soTEm-Y7-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <skegq-8a2-33@gated-at.bofh.it> <soBep-5lJ-1@gated-at.bofh.it> <soGH7-ug-11@gated-at.bofh.it> <soRVT-86P-7@gated-at.bofh.it> <soS5z-8ff-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 05, 2016 at 07:50:36AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 05, 2016 at 07:45:17AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Oct 05, 2016 at 12:46:12AM +0200, Jiri Olsa escreveu:
> > > On Tue, Oct 04, 2016 at 01:50:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > > > > Adding dcacheline dimension key support. It
> > > > > displays cacheline address as hex number.
> > > > > 
> > > > > Using c2c wrapper to standard 'dcacheline' object
> > > > > to defined own header and simple (just address)
> > > > > cacheline output.
> > > > 
> > > > So, at this point I move from:
> > > > 
> > > >   # perf c2c report
> > > >    Error: Invalid --fields key: `dcacheline'
> > > >   #
> > > > 
> > > > To:
> > > > 
> > > >   [root@jouet ~]# perf c2c report
> > > >   Error: Unknown --fields key: `offset'
> > > >   Segmentation fault (core dumped)
> > > >   [root@jouet ~]#
> > > 
> > > oops, attached patch should fix that, but I needed to change
> > > following patches:
> 
> Now we're at:
> 
> [root@jouet ~]# perf c2c report
>   Error: Unknown --fields key: `offset'
> 0x50cbc0 [0x8]: failed to process type: 68
> failed to process sample
> [root@jouet ~]#

well thats because we implicitly sort by offset but
there's no 'offset' ket support yet in your branch

basically the perf report does not display/do anything
till following patch:

  perf c2c report: Add stdio output support

I made sure now that the perf c2c report wont crash
till that patch..

jirka

Thread

Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-04 19:00 +0200
  Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Jiri Olsa <jolsa@redhat.com> - 2016-10-05 00:50 +0200
    Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 12:50 +0200
      Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:00 +0200
        Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Jiri Olsa <jolsa@redhat.com> - 2016-10-05 14:40 +0200
          Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 15:30 +0200

csiph-web