Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key
Date	2016-10-05 13:10 +0200
Message-ID	<soSff-bT-9@gated-at.bofh.it> (permalink)
References	<skegp-8a2-3@gated-at.bofh.it> <skegq-8a2-33@gated-at.bofh.it> <soSff-bT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Wed, Oct 05, 2016 at 08:01:41AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > +
> > +	return snprintf(hpp->buf, hpp->size, "%*s", width, hex_str(addr));
> 
> So here you get that static buffer and then truncate it? Wouldn't the
> perf_hpp stuff take care of this? Can't we stop using that static buffer
> and this truncation at such a level?

So please consider continuing from what I left at the tmp.perf/c2c.2
branch in my tree,

Thanks,

- Arnaldo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:10 +0200

csiph-web