Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495746

Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic context

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic context
Date 2016-10-05 10:10 +0200
Message-ID <soPr4-6yF-7@gated-at.bofh.it> (permalink)
References <sjQe5-1dU-5@gated-at.bofh.it> <skBG1-6fB-3@gated-at.bofh.it> <sobtD-5uk-3@gated-at.bofh.it> <sobMZ-5Bt-9@gated-at.bofh.it> <sopwB-5XC-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 04, 2016 at 03:29:33PM +1100, Michael Ellerman wrote:

SNIP

> Which is where we cope with the possibility that we couldn't emulate the
> instruction that hit the breakpoint. Seems that is not an issue on x86,
> or it's handled elsewhere?
> 
> We should fix emulate_step() if it failed to emulate something it
> should have, but there will always be the possibility that it fails.
> 
> Instead of calling perf_event_disable() we could just add a flag to
> arch_hw_breakpoint that says we hit an error on the event, and block
> reinstalling it in arch_install_hw_breakpoint().

ok, might be easier.. I'll check on that

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Peter Zijlstra <peterz@infradead.org> - 2016-09-23 18:40 +0200
  Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Jiri Olsa <jolsa@redhat.com> - 2016-10-03 15:30 +0200
    Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Peter Zijlstra <peterz@infradead.org> - 2016-10-03 15:50 +0200
      Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic context Michael Ellerman <mpe@ellerman.id.au> - 2016-10-04 06:30 +0200
        Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Peter Zijlstra <peterz@infradead.org> - 2016-10-04 09:10 +0200
          Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Will Deacon <will.deacon@arm.com> - 2016-10-10 15:30 +0200
        Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Jiri Olsa <jolsa@redhat.com> - 2016-10-05 10:10 +0200
          Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Jiri Olsa <jolsa@redhat.com> - 2016-10-05 22:00 +0200
            Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic  context Peter Zijlstra <peterz@infradead.org> - 2016-10-06 09:30 +0200
              [PATCHv2] perf powerpc: Don't call perf_event_disable from atomic  context Jiri Olsa <jolsa@redhat.com> - 2016-10-06 14:40 +0200

csiph-web