Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495730

Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode

Show all headers | View raw

On 28/09/16 14:41, Adrian Hunter wrote:
> In cycle-accurate mode, timestamps can be calculated from CYC packets. The
> decoder also estimates timestamps based on the number of instructions since
> the last timestamp. For that to work in cycle-accurate mode, the
> instruction count needs to be reset to zero when a timestamp is calculated
> from a CYC packet, but that wasn't happening, so fix it.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: stable@vger.kernel.org # v4.3+

Hi

These 2 patches are still outstanding when you have time.

Regards
Adrian

> ---
>  tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> index 7591a0c37473..3d1d446f037f 100644
> --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> @@ -1353,6 +1353,8 @@ static void intel_pt_calc_cyc_timestamp(struct intel_pt_decoder *decoder)
>  			     timestamp, decoder->timestamp);
>  	else
>  		decoder->timestamp = timestamp;
> +
> +	decoder->timestamp_insn_cnt = 0;
>  }
>  
>  /* Walk PSB+ packets when already in sync. */
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode Adrian Hunter <adrian.hunter@intel.com> - 2016-09-28 13:50 +0200
  [PATCH 2/2] perf intel-pt: Fix MTC timestamp calculation for large MTC periods Adrian Hunter <adrian.hunter@intel.com> - 2016-09-28 13:50 +0200
    [tip:perf/urgent] perf intel-pt: Fix MTC timestamp calculation for  large MTC periods tip-bot for Adrian Hunter <tipbot@zytor.com> - 2016-10-07 00:50 +0200
  Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for  cycle-accurate mode Adrian Hunter <adrian.hunter@intel.com> - 2016-10-05 09:40 +0200
    Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for  cycle-accurate mode Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-05 13:20 +0200
  [tip:perf/urgent] perf intel-pt: Fix estimated timestamps for  cycle-accurate mode tip-bot for Adrian Hunter <tipbot@zytor.com> - 2016-10-07 00:50 +0200

csiph-web