Re: [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support
Date	2016-10-05 05:30 +0200
Message-ID	<soL45-3sX-9@gated-at.bofh.it> (permalink)
References	<sne0x-7A2-5@gated-at.bofh.it> <sne0x-7A2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 30-09-16, 14:56, Markus Mayer wrote:
> In order to aid debugging, we add a debugfs interface to the driver
> that allows direct interaction with the AVS co-processor.
> 
> The debugfs interface provides a means for reading all and writing some
> of the mailbox registers directly from the shell prompt and enables a
> user to execute the communications protocol between ARM CPU and AVS CPU
> step-by-step.
> 
> This interface should be used for debugging purposes only.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>  drivers/cpufreq/brcmstb-avs-cpufreq.c | 319 ++++++++++++++++++++++++++++++++++
>  1 file changed, 319 insertions(+)

I am not sure how much useful this is going to be, but I don't have
any concerns against this as well.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Thread

[RESEND PATCH v2 0/3] Broadcom AVS CPUfreq driver Markus Mayer <mmayer@broadcom.com> - 2016-10-01 00:00 +0200
  [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support Markus Mayer <mmayer@broadcom.com> - 2016-10-01 00:00 +0200
    Re: [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs  support Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-05 05:30 +0200
  [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs Markus Mayer <mmayer@broadcom.com> - 2016-10-01 00:00 +0200
    Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-05 05:30 +0200
      Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Markus Mayer <markus.mayer@broadcom.com> - 2016-10-05 23:10 +0200
        Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-06 06:10 +0200
          Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Markus Mayer <markus.mayer@broadcom.com> - 2016-10-06 17:00 +0200
            Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Markus Mayer <mmayer@broadcom.com> - 2016-10-06 23:10 +0200
              Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-07 05:50 +0200
            Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq  driver for Broadcom STB SoCs Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-07 05:40 +0200
  [RESEND PATCH v2 1/3] dt: cpufreq: brcm: New binding document for brcmstb-avs-cpufreq Markus Mayer <mmayer@broadcom.com> - 2016-10-01 00:00 +0200
    Re: [RESEND PATCH v2 1/3] dt: cpufreq: brcm: New binding document  for brcmstb-avs-cpufreq Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-05 05:30 +0200
  Re: [RESEND PATCH v2 0/3] Broadcom AVS CPUfreq driver Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-03 05:30 +0200

csiph-web