Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

From	Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()
Date	2016-10-05 04:40 +0200
Message-ID	<soKhI-2VX-3@gated-at.bofh.it> (permalink)
References	<s077P-7Eh-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-29-07 at 03:55:34 UTC, Andrew Donnellan wrote:
> Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use
> for_each_child_of_node() rather than a hand-coded for loop.
> 
> Remove the useless of_node_put(afu_np) call after the loop, where it's
> guaranteed that afu_np == NULL.
> 
> Reported-by: SF Markus Elfring <elfring@users.sourceforge.net>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Reviewed-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/735840b44bcc998e2574faf63d1aaa

cheers

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put() Michael Ellerman <patch-notifications@ellerman.id.au> - 2016-10-05 04:40 +0200

csiph-web