Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework
Date	2016-10-05 04:30 +0200
Message-ID	<soK81-2Sa-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <sjX5T-5Jq-21@gated-at.bofh.it> <sk8NI-4AG-33@gated-at.bofh.it> <skdaG-7wd-25@gated-at.bofh.it> <slSbL-4TA-1@gated-at.bofh.it> <sm21s-2jb-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Emilio López <emilio.lopez@collabora.co.uk> writes:

> Hi,
>
> El 27/09/16 a las 01:23, Michael Ellerman escribió:
>> Emilio López <emilio.lopez@collabora.co.uk> writes:
>>> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>>>> Emilio López <emilio.lopez@collabora.co.uk> writes:
>>>>
>>>> Please don't include the *kernel* headers, they're really not meant to
>>>> be used in userspace programs :)
>>>>
>>>>> +CFLAGS += -I../../../../usr/include/
>>>>
>>>> That is the correct place to get them from. They'll have been put there
>>>> by 'make headers_install'.
>>>
>>> My inspiration here has been tools/testing/selftests/memfd/Makefile,
>>> which does it this way. If I only include the ones on usr then it
>>> doesn't build, as there's no sync_file.h available, even after running
>>> make headers_install. How am I supposed to use the ioctls from there?
>>
>> It looks like it's missing from include/uapi/linux/Kbuild, you need to
>> add it to the list of exported headers:
>
> I tried that over the weekend and it worked, but I wondered if it was 
> the way to go. Thanks for the confirmation :) I've sent a patch for 
> that[0] now.

Great thanks.

> With that resolved, CFLAGS can just be
>
> CFLAGS += -O2 -g -std=gnu89 -pthread -Wall -Wextra
> CFLAGS += -I../../../../usr/include/

LGTM.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework Michael Ellerman <mpe@ellerman.id.au> - 2016-09-27 06:30 +0200
  Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework Emilio López <emilio.lopez@collabora.co.uk> - 2016-09-27 17:00 +0200
    Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework Michael Ellerman <mpe@ellerman.id.au> - 2016-10-05 04:30 +0200

csiph-web