Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1494794

Re: [PATCH] hid-led.c: remove unneccessary underscores

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] hid-led.c: remove unneccessary underscores
Date 2016-10-03 11:50 +0200
Message-ID <so82O-39b-11@gated-at.bofh.it> (permalink)
References <so6DD-22l-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon 2016-10-03 10:16:26, Pavel Machek wrote:
> 
> u8 (and friends) can be used directly in kernel sources (not kernel
> headers).
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Zero day bot warned me that this is not quiet correct.

This would be needed on top. Is there interest in fixed patch?

diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c
index cd208ca..be659ca 100644
--- a/drivers/hid/hid-led.c
+++ b/drivers/hid/hid-led.c
@@ -57,8 +57,8 @@ union delcom_packet {
 		u8 cmd;
 	} rx;
 	struct {
-		le16 family_code;
-		le16 security_code;
+		__le16 family_code;
+		__le16 security_code;
 		u8 fw_version;
 	} fw;
 };


Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] hid-led.c: remove unneccessary underscores Pavel Machek <pavel@ucw.cz> - 2016-10-03 10:20 +0200
  Re: [PATCH] hid-led.c: remove unneccessary underscores Pavel Machek <pavel@ucw.cz> - 2016-10-03 11:50 +0200
    Re: [PATCH] hid-led.c: remove unneccessary underscores Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-10-07 18:30 +0200
      Re: [PATCH] hid-led.c: remove unneccessary underscores Heiner Kallweit <hkallweit1@gmail.com> - 2016-10-07 20:50 +0200

csiph-web