Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494784

Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build

Show all headers | View raw

On Mon, Oct 3, 2016 at 11:07 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> It can be built even on systems without ISA. So enable compile testing
> by specifying ISA || COMPILE_TEST.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: <linux-fbdev@vger.kernel.org>
> ---
>  drivers/video/console/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index 38da6e299149..7e9e8be24134 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -48,7 +48,7 @@ config VGACON_SOFT_SCROLLBACK_SIZE
>          screenfuls of scrollback buffer
>
>  config MDA_CONSOLE
> -       depends on !M68K && !PARISC && ISA
> +       depends on !M68K && !PARISC && (ISA || COMPILE_TEST)

My first thought was

    depends on (!M68K && !PARISC && ISA) || COMPILE_TEST

but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM().
Adding #include <asm-generic/vga.h> at the end of arch/m68k/include/asm/vga.h
fixes that.

Do we want that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -resend 1/6] mdacon: align code in mda_detect properly Jiri Slaby <jslaby@suse.cz> - 2016-10-03 11:10 +0200
  [PATCH -resend 2/6] mdacon: make mda_vram_base u16 * Jiri Slaby <jslaby@suse.cz> - 2016-10-03 11:10 +0200
  [PATCH -resend 5/6] m32r, microblaze, x86, xtensa: use generic vga.h Jiri Slaby <jslaby@suse.cz> - 2016-10-03 11:10 +0200
    Re: [PATCH -resend 5/6] m32r, microblaze, x86, xtensa: use generic vga.h Max Filippov <jcmvbkbc@gmail.com> - 2016-10-03 19:10 +0200
  [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build Jiri Slaby <jslaby@suse.cz> - 2016-10-03 11:10 +0200
    Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-03 11:40 +0200
      Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build Jiri Slaby <jslaby@suse.cz> - 2016-10-04 09:10 +0200
  [PATCH -resend 3/6] mdacon: replace MDA_ADDR macro by inline function Jiri Slaby <jslaby@suse.cz> - 2016-10-03 11:10 +0200

csiph-web