Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning
Date	2016-10-03 08:00 +0200
Message-ID	<so4sa-8tW-7@gated-at.bofh.it> (permalink)
References	<sn8Hv-4bK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 30 Sep 2016 18:17:09 +0200

> Build-testing this driver with -Wmaybe-uninitialized gives a new false-positive
> warning that I can't really explain:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_configure_flower':
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:509:3: error: 'old_attr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> It's obvious from the code that 'old_attr' is initialized whenever 'old'
> is non-NULL here. The warning appears with all versions I tested from gcc-4.7
> through gcc-6.1, and I could not come up with a way to rewrite the function
> in a more readable way that avoids the warning, so I'm adding another
> initialization to shut it up.
> 
> Fixes: 8b32580df1cb ("net/mlx5e: Add TC vlan action for SRIOV offloads")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-09-30 18:20 +0200
  Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning Or Gerlitz <gerlitz.or@gmail.com> - 2016-10-01 17:10 +0200
  Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning David Miller <davem@davemloft.net> - 2016-10-03 08:00 +0200

csiph-web