Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494488

Re: [PATCH 14/15] irqchip/metag-ext: improve function-level documentation

Show all headers | View raw

Hi Julia,

On 1 October 2016 at 20:46, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Drop the variable irq which ceased to be a parameter in bd0b9ac4.

I think 12 nibbles of the hash is recommended now due to collisions,
as is quoting the subject line, e.g. commit bd0b9ac405e1 ("genirq:
Remove irq argument from irq flow handlers").

>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: James Hogan <james.hogan@imgtec.com>

Thanks
James

>
> ---
>  drivers/irqchip/irq-metag-ext.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-metag-ext.c b/drivers/irqchip/irq-metag-ext.c
> index 8c38b3d..0cdd923 100644
> --- a/drivers/irqchip/irq-metag-ext.c
> +++ b/drivers/irqchip/irq-metag-ext.c
> @@ -436,7 +436,6 @@ static int meta_intc_irq_set_type(struct irq_data *data, unsigned int flow_type)
>
>  /**
>   * meta_intc_irq_demux() - external irq de-multiplexer
> - * @irq:       the virtual interrupt number
>   * @desc:      the interrupt description structure for this irq
>   *
>   * The cpu receives an interrupt on TR2 when a SoC interrupt has occurred. It is
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 14/15] irqchip/metag-ext: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
    Re: [PATCH 14/15] irqchip/metag-ext: improve function-level documentation James Hogan <james.hogan@imgtec.com> - 2016-10-01 22:40 +0200
    [tip:irq/urgent] irqchip/metag-ext: Improve function-level  documentation tip-bot for Julia Lawall <tipbot@zytor.com> - 2016-10-05 12:00 +0200
  [PATCH 06/15] mfd: tc3589x: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 10/15] clk: keystone: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 01/15] UBIFS: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 07/15] clk: sunxi: mod0: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
    Re: [PATCH 07/15] clk: sunxi: mod0: improve function-level  documentation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-04 23:10 +0200
  [PATCH 11/15] kobject: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 12/15] clk: tegra: dfll: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  [PATCH 09/15] gma500: improve function-level documentation Julia Lawall <Julia.Lawall@lip6.fr> - 2016-10-01 22:10 +0200
  Re: [PATCH 00/15] improve function-level documentation Joe Perches <joe@perches.com> - 2016-10-01 22:30 +0200
    Re: [PATCH 00/15] improve function-level documentation Julia Lawall <julia.lawall@lip6.fr> - 2016-10-01 22:40 +0200
  Re: [PATCH 00/15] improve function-level documentation Daniel Vetter <daniel@ffwll.ch> - 2016-10-05 15:20 +0200
    kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation) Jani Nikula <jani.nikula@linux.intel.com> - 2016-10-05 16:10 +0200
      Re: kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation) Markus Heiser <markus.heiser@darmarit.de> - 2016-10-05 19:30 +0200
      Re: kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level  documentation) Julia Lawall <julia.lawall@lip6.fr> - 2016-10-05 22:30 +0200
    Re: [PATCH 00/15] improve function-level documentation Julia Lawall <julia.lawall@lip6.fr> - 2016-10-05 16:50 +0200

csiph-web