Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494391

Re: [PATCH] iio: Declare event_attrs field of iio_info structure as const

Show all headers | View raw

On 01/10/16 10:57, Bhumika Goyal wrote:
> The event_attrs field of iio_info structure is only initialized once
> whenever an object of iio_info is created. After that this field
> is never modified again anywhere in the kernel. So, declare event_attrs
> field of iio_info as a const struct attribute_group.
> Checked for occurences throughout the kernel using grep and
> coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Clearly this becomes more interesting when the follow up patches
making ever event_attr group we can constant. 
Looking forward to those ;)


Jonathan
> ---
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index b4a0679..4591d8e 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -381,7 +381,7 @@ struct iio_dev;
>   **/
>  struct iio_info {
>  	struct module			*driver_module;
> -	struct attribute_group		*event_attrs;
> +	const struct attribute_group	*event_attrs;
>  	const struct attribute_group	*attrs;
>  
>  	int (*read_raw)(struct iio_dev *indio_dev,
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: Declare event_attrs field of iio_info structure as const Bhumika Goyal <bhumirks@gmail.com> - 2016-10-01 12:00 +0200
  Re: [PATCH] iio: Declare event_attrs field of iio_info structure as  const Jonathan Cameron <jic23@kernel.org> - 2016-10-01 13:10 +0200
    Re: [PATCH] iio: Declare event_attrs field of iio_info structure as const Bhumika Goyal <bhumirks@gmail.com> - 2016-10-01 13:50 +0200

csiph-web